Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-19772: update composer dependencies first round. #19955

Merged
merged 27 commits into from
Dec 11, 2024

Conversation

JakeBapple
Copy link
Contributor

Description

This PR encapsulates the work for updating modules and exporting configurations related. A full list of the updates are here: https://docs.google.com/spreadsheets/d/1exMktEjiY9CaKtzvh0Qi-F8ffuDz-jJ5LXMuHVx4cu0/edit?usp=sharing

Relates to #19772

Testing done

Local logs and spot checking.

QA steps

What needs to be checked to prove this works?
Look at list of composer modules updated to see if it matches expectations.
What needs to be checked to prove it didn't break any related things?
Site shouldn't change any functionality or look.
What variations of circumstances (users, actions, values) need to be checked?

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@JakeBapple JakeBapple added the CMS Team CMS Product team that manages both editor exp and devops label Nov 25, 2024
@JakeBapple JakeBapple self-assigned this Nov 25, 2024
@JakeBapple JakeBapple requested review from a team as code owners November 25, 2024 15:44
@JakeBapple JakeBapple linked an issue Nov 25, 2024 that may be closed by this pull request
3 tasks
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 25, 2024 15:44 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 26, 2024 09:02 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 26, 2024 15:24 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 27, 2024 08:55 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 27, 2024 15:59 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 27, 2024 18:58 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 28, 2024 08:48 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2024 08:48 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat November 29, 2024 15:37 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 17:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 19:19 Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 3, 2024 21:14 Destroyed
Copy link

github-actions bot commented Dec 3, 2024

Checking composer.lock changes...

@JakeBapple
Copy link
Contributor Author

Keeping track of all modules updated or not in this sheet: https://docs.google.com/spreadsheets/d/1exMktEjiY9CaKtzvh0Qi-F8ffuDz-jJ5LXMuHVx4cu0/edit?usp=sharing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 4, 2024 08:47 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 5, 2024 08:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 9, 2024 08:44 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 10, 2024 08:42 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 10, 2024 15:19 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 11, 2024 08:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 11, 2024 16:43 Destroyed
Copy link

Checking composer.lock changes...

@va-cms-bot
Copy link
Collaborator

Cypress Accessibility Violations

/test-data-repudiandae

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, ACT, TTv5, TT6.a
Description: Ensures buttons have discernible text
Help: Buttons must have discernible text
Nodes:

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
    Impact: critical
    Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

  • HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
    Impact: critical
    Target: button[data-proofing-help-title="About 'Main content' field"]
    Summary: Fix any of the following:
    Element does not have inner text that is visible to screen readers
    aria-label attribute does not exist or is empty
    aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
    Element has no title attribute
    Element's default semantics were not overridden with role="none" or role="presentation"

Copy link
Contributor

@edmund-dunn edmund-dunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!!

@JakeBapple JakeBapple merged commit 0ed827f into main Dec 11, 2024
18 checks passed
@JakeBapple JakeBapple deleted the 19772-update-composer-dependencies branch December 11, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update composer dependencies
3 participants